Use automatic port for UDP send #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mcasper
reviewed
Apr 11, 2017
| @@ -17,8 +17,8 @@ Build an options struct and create a client: | |||
| ```rust | |||
| use dogstatsd::{Client, Options}; | |||
|
|
|||
| // Binds to a udp socket on 127.0.0.1:8126 for transmitting, and sends to | |||
| // 127.0.0.1:8125, the default dogstatsd address. | |||
| // Binds to a udp socket on an available ephemeral port on 127.0.0.1 for | |||
There was a problem hiding this comment.
It looks like this might have gotten a tad messed up, we're sending to 127.0.0.1:8125, right?
There was a problem hiding this comment.
Ooops, you're absolutely right. I fixed this up and pushed a new commit.
Use an automatically-assigned free UDP port in the ephemeral port range for sending by default. Since none of the DataDog metrics require two-way communication, the assigned port number does not need to be remembered/exposed. Signed-off-by: Nick Stevens <nick@bitcurry.com>
nastevens
force-pushed
the
use-automatic-udp-port
branch
from
b943545 to
95fb0ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an automatically-assigned free UDP port in the ephemeral port range for sending by default. Since none of the DataDog metrics require two-way communication, the assigned port number does not need to be remembered/exposed.
This avoids port conflicts if more than one
Clientis being used at the same time from different threads.